azures04/crafatar
1
0
Fork 0
mirror of https://github.com/azures04/crafatar.git synced 2026-03-21 23:41:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

use splice instead of delete

Browse Source 
`delete` replaces the value with undefined and doesn't shrink the array size
`splice` actually removes the value and shrinkgs the array size
This commit is contained in:
jomo 2015-01-28 23:35:53 +01:00
parent 74f1618aa3
commit 1c2c7f0956
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/helpers.js
View File

@ -81,7 +81,7 @@ function store_cape(uuid, profile, details, callback) {
} else {
skins.save_image(img, capepath, function(err) {
logging.log(uuid + " cape saved");
callback(err, hash);
callback(err, hash);
});
}
});
@ -104,8 +104,8 @@ function callback_for(uuid, which, err, cape_hash, skin_hash) {
if (currently_running[i] && currently_running[i].uuid === uuid && (currently_running[i].which === which || which === null)) {
var will_call = currently_running[i];
will_call.callback(err, will_call.which === 'skin' ? skin_hash : cape_hash);
//remove_from_array(currently_running, i);
delete(currently_running[i]);
currently_running.splice(i, 1); // remove from array
i--;
}
}
}