azures04/crafatar
1
0
Fork 0
mirror of https://github.com/azures04/crafatar.git synced 2026-03-21 23:41:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

don't rely on hasOwnProperty to exist

Browse Source 
from MDN:
JavaScript does not protect the property name hasOwnProperty; thus, if the possibility exists that an object might have a property with this name, it is necessary to use an external hasOwnProperty to get correct results
This commit is contained in:
jomo 2016-11-04 16:19:12 +01:00
parent c6c203fc5e
commit 57115202d2
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/object-patch.js
View File

@ -11,7 +11,7 @@ Object.get = function(obj, pathstr) {
for (var i = 0; i < path.length; i++) { for (var i = 0; i < path.length; i++) {
var key = path[i]; var key = path[i];
if (!result || !result.hasOwnProperty(key)) { if (!result || !Object.prototype.hasOwnProperty.call(result, key)) {
return undefined; return undefined;
} else { } else {
result = result[key]; result = result[key];

2
lib/routes/avatars.js
View File

@ -55,7 +55,7 @@ module.exports = function(req, callback) {
var userId = (req.url.path_list[1] || "").split(".")[0]; var userId = (req.url.path_list[1] || "").split(".")[0];
var size = parseInt(req.url.query.size) || config.avatars.default_size; var size = parseInt(req.url.query.size) || config.avatars.default_size;
var def = req.url.query.default; var def = req.url.query.default;
var overlay = req.url.query.hasOwnProperty("overlay") || req.url.query.hasOwnProperty("helm"); var overlay = Object.prototype.hasOwnProperty.call(req.url.query, "overlay") || Object.prototype.hasOwnProperty.call(req.url.query, "helm");
// check for extra paths // check for extra paths
if (req.url.path_list.length > 2) { if (req.url.path_list.length > 2) {

2
lib/routes/renders.js
View File

@ -64,7 +64,7 @@ module.exports = function(req, callback) {
var userId = (req.url.path_list[2] || "").split(".")[0]; var userId = (req.url.path_list[2] || "").split(".")[0];
var def = req.url.query.default; var def = req.url.query.default;
var scale = parseInt(req.url.query.scale) || config.renders.default_scale; var scale = parseInt(req.url.query.scale) || config.renders.default_scale;
var overlay = req.url.query.hasOwnProperty("overlay") || req.url.query.hasOwnProperty("helm"); var overlay = Object.prototype.hasOwnProperty.call(req.url.query, "overlay") || Object.prototype.hasOwnProperty.call(req.url.query, "helm");
// check for extra paths // check for extra paths
if (req.url.path_list.length > 3) { if (req.url.path_list.length > 3) {