azures04/crafatar
1
0
Fork 0
mirror of https://github.com/azures04/crafatar.git synced 2026-03-22 07:51:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

TooManyRequestsException shouldn't actually throw an error

Browse Source 
all other errors thrown here are network issues, this is not.
This commit is contained in:
jomo 2015-09-20 21:43:12 +02:00
parent 06895cdd81
commit a15cb20144
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/networking.js
View File

@ -88,16 +88,12 @@ exp.get_from_options = function(rid, url, options, callback) {
break; break;
case 404: case 404:
case 204: case 204:
case 429: // this shouldn't usually happen, but occasionally does
case 500: case 500:
case 503: case 503:
// we don't want to cache this // we don't want to cache this
body = null; body = null;
break; break;
case 429:
// this shouldn't usually happen, but occasionally does
// forcing error so it's not cached
error = error || new Error("TooManyRequestsException");
break;
default: default:
if (!error) { if (!error) {
// Probably 500 or the likes // Probably 500 or the likes

2
lib/response.js
View File

@ -13,7 +13,7 @@ var human_status = {
// print these, but without stacktrace // print these, but without stacktrace
var silent_errors = ["ETIMEDOUT", "ESOCKETTIMEDOUT", "ECONNRESET", "EHOSTUNREACH", "ECONNREFUSED", "TooManyRequestsException"]; var silent_errors = ["ETIMEDOUT", "ESOCKETTIMEDOUT", "ECONNRESET", "EHOSTUNREACH", "ECONNREFUSED"];
// handles HTTP responses // handles HTTP responses
// +request+ a http.IncomingMessage // +request+ a http.IncomingMessage

4
test/test.js
View File

@ -1013,8 +1013,8 @@ describe("Crafatar", function() {
it("uuid should be rate limited", function(done) { it("uuid should be rate limited", function(done) {
networking.get_profile(rid, id, function() { networking.get_profile(rid, id, function() {
networking.get_profile(rid, id, function(err, profile) { networking.get_profile(rid, id, function(err, profile) {
assert.strictEqual(err.message, "TooManyRequestsException"); assert.ifError(err);
assert.strictEqual(profile.error, "TooManyRequestsException"); assert.strictEqual(profile, null);
done(); done();
}); });
}); });