azures04/crafatar
1
0
Fork 0
mirror of https://github.com/azures04/crafatar.git synced 2026-03-22 07:51:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Change invalid request path to be a 404 rather than 422, implement status id in response module

Browse Source
This commit is contained in:
Jake 2015-07-16 17:48:48 -05:00
parent d71d99fa9a
commit b1cdf61e4b
6 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/response.js
View File

@ -77,7 +77,10 @@ module.exports = function(request, response, result) {
return; return;
} }
if (result.status === -2) { if (result.status === -3) {
response.writeHead(404, headers);
response.end(result.body);
} else if (result.status === -2) {
response.writeHead(422, headers); response.writeHead(422, headers);
response.end(result.body); response.end(result.body);
} else if (result.status === -1) { } else if (result.status === -1) {

2
lib/routes/avatars.js
View File

@ -52,7 +52,7 @@ module.exports = function(req, callback) {
// check for extra paths // check for extra paths
if (req.url.path_list.length > 2) { if (req.url.path_list.length > 2) {
callback({ callback({
status: -2, status: -3,
body: "Invalid URL Path" body: "Invalid URL Path"
}); });
return; return;

2
lib/routes/capes.js
View File

@ -11,7 +11,7 @@ module.exports = function(req, callback) {
// check for extra paths // check for extra paths
if (req.url.path_list.length > 2) { if (req.url.path_list.length > 2) {
callback({ callback({
status: -2, status: -3,
body: "Invalid URL Path" body: "Invalid URL Path"
}); });
return; return;

2
lib/routes/renders.js
View File

@ -62,7 +62,7 @@ module.exports = function(req, callback) {
// check for extra paths // check for extra paths
if (req.url.path_list.length > 3) { if (req.url.path_list.length > 3) {
callback({ callback({
status: -2, status: -3,
body: "Invalid URL Path" body: "Invalid URL Path"
}); });
return; return;

2
lib/routes/skins.js
View File

@ -59,7 +59,7 @@ module.exports = function(req, callback) {
// check for extra paths // check for extra paths
if (req.url.path_list.length > 2) { if (req.url.path_list.length > 2) {
callback({ callback({
status: -2, status: -3,
body: "Invalid URL Path" body: "Invalid URL Path"
}); });
return; return;

6
test/test.js
View File

@ -859,10 +859,10 @@ describe("Crafatar", function() {
}); });
}); });
it("should return a 422 (invalid request path " + location + ")", function(done) { it("should return a 404 (invalid request path " + location + ")", function(done) {
request.get("http://localhost:3000/" + location + "/thisisaninvaliduuid/invalid", function(error, res, body) { request.get("http://localhost:3000/" + location + "/853c80ef3c3749fdaa49938b674adae6/invalid", function(error, res, body) {
assert.ifError(error); assert.ifError(error);
assert.strictEqual(res.statusCode, 422); assert.strictEqual(res.statusCode, 404);
done(); done();
}); });
}); });